scripts/slave/recipes/v8/auto_tag.py - Issue 1314823010: V8 Buildbot: Fix strange bug with step names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8/auto_tag.py

Issue 1314823010: V8 Buildbot: Fix strange bug with step names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipes/v8/auto_tag.py

diff --git a/scripts/slave/recipes/v8/auto_tag.py b/scripts/slave/recipes/v8/auto_tag.py

index 3706f86b2924b899dac4e73b6330ca00d2a28fbb..7845963b9aa8dbb5cd7a4f304a944439e0c4e5d3 100644

--- a/scripts/slave/recipes/v8/auto_tag.py

+++ b/scripts/slave/recipes/v8/auto_tag.py

@@ -23,7 +23,9 @@ BRANCH_RE = re.compile(r'^\d+\.\d+$')

def GetCommitForRef(api, repo, ref):

step_result = api.git(

'ls-remote', repo, ref,

- name='git ls-remote %s' % ref.split('/')[-1],

+ # For strange reasons, this string is not a string in production without

+ # str().

+ name=str('git ls-remote %s' % ref.split('/')[-1]),

cwd=api.path['checkout'],

stdout=api.raw_io.output(),

)

« no previous file with comments | « no previous file | no next file » | no next file with comments »