Remove overly complicated GR_CREATE_STATIC_PROCESSOR macro

Remove overly complicated GR_CREATE_STATIC_PROCESSOR macro

This macro was responsible for producing code like:

    static SkAlignedStorage<sizeof(Foo)> g_gFoo_Storage;
    static Foo* gFoo = new(g_gFoo_Storage.get()) Foo;
    static SkAutoTDestroy<Foo> gFoo_ad(gFoo);

which would allocate static storage for an object of type Foo
(g_gFoo_Storage), lazily instantiate the object in that memory (via
gFoo's initializer), and then ensure that at global destruction time
the object is destroyed (via gFoo_Ad's destructor).

However, the exact same effect is achieved by just writing:

    static Foo gFoo;

Committed: https://skia.googlesource.com/skia/+/38f1f6f9e590fc20b81015ceca9d642cbe02a2d9

[mdempsky, 2015-08-27 18:38:52]

mdempsky@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein, 2015-08-27 18:59:47]

mtklein@google.com changed reviewers:
+ bsalomon@google.com, mtklein@google.com

[mtklein, 2015-08-27 18:59:47]

mtklein@google.com changed required reviewers:
+ bsalomon@google.com

[mtklein, 2015-08-27 18:59:48]

lgtm

It doesn't look like this changes:
  - thread safety (not thread safe before, not thread safe after)
  - how much we annoy Chrome (no global constructors before, no global
constructors after)

It's way more readable too.

Let's just make sure Brian's on board.

[bsalomon, 2015-08-27 19:42:50]

On 2015/08/27 18:59:48, mtklein wrote:
> lgtm
> 
> It doesn't look like this changes:
>   - thread safety (not thread safe before, not thread safe after)
>   - how much we annoy Chrome (no global constructors before, no global
> constructors after)
> 
> It's way more readable too.
> 
> Let's just make sure Brian's on board.

lgtm, I can't recall why we did this originally but it clearly doesn't seem to
be necessary now.

[mtklein, 2015-08-27 19:51:01]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-08-27 19:51:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1314763009/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1314763009/1

[commit-bot: I haz the power, 2015-08-27 19:57:04]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/38f1f6f9e590fc20b81015ceca9d642cbe02a2d9