Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: include/gpu/GrProcessor.h

Issue 1314763009: Remove overly complicated GR_CREATE_STATIC_PROCESSOR macro (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/effects/SkLumaColorFilter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/GrProcessor.h
diff --git a/include/gpu/GrProcessor.h b/include/gpu/GrProcessor.h
index c1f4aa0256ca0af7a6080c349bf4f0a7d4c18da1..7c24f549f0caf6ecf0109774c28b84fc232b8db5 100644
--- a/include/gpu/GrProcessor.h
+++ b/include/gpu/GrProcessor.h
@@ -52,8 +52,7 @@ private:
immutable: after being constructed, their fields may not change.
Dynamically allocated GrProcessors are managed by a per-thread memory pool. The ref count of an
- processor must reach 0 before the thread terminates and the pool is destroyed. To create a
- static processor use the helper macro GR_CREATE_STATIC_PROCESSOR declared below.
+ processor must reach 0 before the thread terminates and the pool is destroyed.
*/
class GrProcessor : public GrProgramElement {
public:
@@ -143,13 +142,4 @@ private:
typedef GrProgramElement INHERITED;
};
-/**
- * This creates a processor outside of the memory pool. The processor's destructor will be called
- * at global destruction time. NAME will be the name of the created instance.
- */
-#define GR_CREATE_STATIC_PROCESSOR(NAME, PROC_CLASS, ARGS) \
-static SkAlignedSStorage<sizeof(PROC_CLASS)> g_##NAME##_Storage; \
-static PROC_CLASS* NAME SkNEW_PLACEMENT_ARGS(g_##NAME##_Storage.get(), PROC_CLASS, ARGS); \
-static SkAutoTDestroy<GrProcessor> NAME##_ad(NAME);
-
#endif
« no previous file with comments | « no previous file | src/effects/SkLumaColorFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698