Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/css3/flexbox/flex-grow-less-than-one.html

Issue 1314703006: Flex grow wrongly calculated for value between 0 and 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/css3/flexbox/flex-grow-less-than-one-expected.txt » ('j') | Source/core/layout/LayoutFlexibleBox.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/css3/flexbox/flex-grow-less-than-one.html
diff --git a/LayoutTests/css3/flexbox/flex-grow-less-than-one.html b/LayoutTests/css3/flexbox/flex-grow-less-than-one.html
new file mode 100644
index 0000000000000000000000000000000000000000..e1133e8de8110695d8bfbebd0513c76d7b0db309
--- /dev/null
+++ b/LayoutTests/css3/flexbox/flex-grow-less-than-one.html
@@ -0,0 +1,70 @@
+<!DOCTYPE html>
+<link href="resources/flexbox.css" rel="stylesheet">
+<style>
+.parent {
harpreet.sk 2015/09/07 13:45:44 Rename it to something more appropriate something
ashlin.j 2015/09/21 06:34:00 Done.
+ height: 100px;
+ width: 100px;
+ border: 1px solid black;
+}
+
+.child-flex-grow-1 {
harpreet.sk 2015/09/07 13:45:44 Rename classes so that it clearly explain what it
ashlin.j 2015/09/21 06:34:00 Done.
+ background-color: green;
+ flex-grow: 0.5;
+}
+
+.child-flex-grow-2 {
harpreet.sk 2015/09/07 13:45:45 Ditto.
ashlin.j 2015/09/21 06:34:00 Done.
+ background-color: red;
+ flex-grow: 0.25;
+}
+.child-flex-grow-3 {
+ background-color: green;
+ flex-grow: 1.5;
+}
+
harpreet.sk 2015/09/07 13:45:44 child flex-grow-3 and 4 are not required. We need
ashlin.j 2015/09/21 06:34:00 Done.
+.child-flex-grow-4 {
+ background-color: red;
+ flex-grow: 1.5;
+}
+
+.vertical {
+ -webkit-writing-mode: vertical-rl;
+}
+
harpreet.sk 2015/09/07 13:45:44 Remove line.
ashlin.j 2015/09/21 06:34:00 Done.
+</style>
+<script src="../../resources/check-layout.js"></script>
+<body onload="checkLayout('.flexbox');">
+<div>Test Case-1</div>
harpreet.sk 2015/09/07 13:45:44 Not required.
ashlin.j 2015/09/21 06:34:00 Done.
+<div class="flexbox parent">
+ <div class="child-flex-grow-1 " data-expected-width="50"></div>
+</div>
+
+<div>Test Case-2</div>
harpreet.sk 2015/09/07 13:45:44 Ditto.
ashlin.j 2015/09/21 06:34:00 Done.
+<div class="flexbox parent">
+ <div class="child-flex-grow-1 " data-expected-width="50"></div>
+ <div class="child-flex-grow-2 " data-expected-width="25"></div>
+</div>
+
+<div>Test Case-3</div>
harpreet.sk 2015/09/07 13:45:45 Ditto.
ashlin.j 2015/09/21 06:34:00 Done.
+<div class="flexbox parent">
+ <div class="child-flex-grow-3 " data-expected-width="50"></div>
+ <div class="child-flex-grow-4 " data-expected-width="50"></div>
+</div>
+
+<div>Test Case-4</div>
harpreet.sk 2015/09/07 13:45:44 Ditto.
ashlin.j 2015/09/21 06:34:00 Done.
+<div class="flexbox parent column">
+ <div class="child-flex-grow-1 " data-expected-height="50"></div>
+ <div class="child-flex-grow-2 " data-expected-height="25"></div>
+</div>
+
+<div>Test Case-5</div>
harpreet.sk 2015/09/07 13:45:44 Ditto.
ashlin.j 2015/09/21 06:34:00 Done.
+<div class="flexbox parent column vertical">
+ <div class="child-flex-grow-1 " data-expected-width="50"></div>
+ <div class="child-flex-grow-2 " data-expected-width="25"></div>
+</div>
+
+<div>Test Case-6</div>
harpreet.sk 2015/09/07 13:45:44 Ditto.
ashlin.j 2015/09/21 06:34:00 Done.
+<div class="flexbox parent vertical">
+ <div class="child-flex-grow-1 " data-expected-height="50"></div>
+ <div class="child-flex-grow-2 " data-expected-height="25"></div>
+</div>
+</body>
« no previous file with comments | « no previous file | LayoutTests/css3/flexbox/flex-grow-less-than-one-expected.txt » ('j') | Source/core/layout/LayoutFlexibleBox.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698