Chromium Code Reviews Chromium Code Reviews
Issue 1314703006:
Flex grow wrongly calculated for value between 0 and 1 (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!DOCTYPE html> | |
| 2 <link href="resources/flexbox.css" rel="stylesheet"> | |
| 3 <style> | |
| 4 .parent { | |
|
harpreet.sk
2015/09/07 13:45:44
Rename it to something more appropriate something
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 5 height: 100px; | |
| 6 width: 100px; | |
| 7 border: 1px solid black; | |
| 8 } | |
| 9 | |
| 10 .child-flex-grow-1 { | |
|
harpreet.sk
2015/09/07 13:45:44
Rename classes so that it clearly explain what it
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 11 background-color: green; | |
| 12 flex-grow: 0.5; | |
| 13 } | |
| 14 | |
| 15 .child-flex-grow-2 { | |
|
harpreet.sk
2015/09/07 13:45:45
Ditto.
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 16 background-color: red; | |
| 17 flex-grow: 0.25; | |
| 18 } | |
| 19 .child-flex-grow-3 { | |
| 20 background-color: green; | |
| 21 flex-grow: 1.5; | |
| 22 } | |
| 23 | |
|
harpreet.sk
2015/09/07 13:45:44
child flex-grow-3 and 4 are not required. We need
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 24 .child-flex-grow-4 { | |
| 25 background-color: red; | |
| 26 flex-grow: 1.5; | |
| 27 } | |
| 28 | |
| 29 .vertical { | |
| 30 -webkit-writing-mode: vertical-rl; | |
| 31 } | |
| 32 | |
|
harpreet.sk
2015/09/07 13:45:44
Remove line.
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 33 </style> | |
| 34 <script src="../../resources/check-layout.js"></script> | |
| 35 <body onload="checkLayout('.flexbox');"> | |
| 36 <div>Test Case-1</div> | |
|
harpreet.sk
2015/09/07 13:45:44
Not required.
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 37 <div class="flexbox parent"> | |
| 38 <div class="child-flex-grow-1 " data-expected-width="50"></div> | |
| 39 </div> | |
| 40 | |
| 41 <div>Test Case-2</div> | |
|
harpreet.sk
2015/09/07 13:45:44
Ditto.
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 42 <div class="flexbox parent"> | |
| 43 <div class="child-flex-grow-1 " data-expected-width="50"></div> | |
| 44 <div class="child-flex-grow-2 " data-expected-width="25"></div> | |
| 45 </div> | |
| 46 | |
| 47 <div>Test Case-3</div> | |
|
harpreet.sk
2015/09/07 13:45:45
Ditto.
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 48 <div class="flexbox parent"> | |
| 49 <div class="child-flex-grow-3 " data-expected-width="50"></div> | |
| 50 <div class="child-flex-grow-4 " data-expected-width="50"></div> | |
| 51 </div> | |
| 52 | |
| 53 <div>Test Case-4</div> | |
|
harpreet.sk
2015/09/07 13:45:44
Ditto.
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 54 <div class="flexbox parent column"> | |
| 55 <div class="child-flex-grow-1 " data-expected-height="50"></div> | |
| 56 <div class="child-flex-grow-2 " data-expected-height="25"></div> | |
| 57 </div> | |
| 58 | |
| 59 <div>Test Case-5</div> | |
|
harpreet.sk
2015/09/07 13:45:44
Ditto.
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 60 <div class="flexbox parent column vertical"> | |
| 61 <div class="child-flex-grow-1 " data-expected-width="50"></div> | |
| 62 <div class="child-flex-grow-2 " data-expected-width="25"></div> | |
| 63 </div> | |
| 64 | |
| 65 <div>Test Case-6</div> | |
|
harpreet.sk
2015/09/07 13:45:44
Ditto.
ashlin.j
2015/09/21 06:34:00
Done.
| |
| 66 <div class="flexbox parent vertical"> | |
| 67 <div class="child-flex-grow-1 " data-expected-height="50"></div> | |
| 68 <div class="child-flex-grow-2 " data-expected-height="25"></div> | |
| 69 </div> | |
| 70 </body> | |
| OLD | NEW |
