Issue 1314683008: win: Add version to client registration request

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1314683008: win: Add version to client registration request (Closed)

Created:
5 years, 3 months ago by scottmg

Modified:
5 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: Add version to client registration request Follow up after suggestion in https://codereview.chromium.org/1301853002/. R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/28c5da90807588a0abfbd4e76f0289c3fca068f7

Patch Set 1 #

Total comments: 2

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -3 lines)			Patch
M	client/crashpad_client_win.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	util/win/exception_handler_server.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	util/win/registration_protocol_win.h	View	1 chunk	+11 lines, -3 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM. In the future, we may want to allow for some amount of cross-versioned operation, ...

5 years, 3 months ago (2015-09-04 16:05:55 UTC) #2

scottmg

https://codereview.chromium.org/1314683008/diff/1/util/win/registration_protocol_win.h File util/win/registration_protocol_win.h (right): https://codereview.chromium.org/1314683008/diff/1/util/win/registration_protocol_win.h#newcode50 util/win/registration_protocol_win.h:50: DWORD client_process_id; On 2015/09/04 16:05:55, Mark Mentovai - August ...

5 years, 3 months ago (2015-09-04 18:50:01 UTC) #3

scottmg

5 years, 3 months ago (2015-09-04 18:52:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
28c5da90807588a0abfbd4e76f0289c3fca068f7 (presubmit successful).

Expand Messages | Collapse Messages