Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: util/win/exception_handler_server.cc

Issue 1314683008: win: Add version to client registration request (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/crashpad_client_win.cc ('k') | util/win/registration_protocol_win.h » ('j') | util/win/registration_protocol_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/exception_handler_server.cc
diff --git a/util/win/exception_handler_server.cc b/util/win/exception_handler_server.cc
index 278d6e1dbf2c75f50eeee99a11fb9c3bcb878292..547087e04be714bcf41feda9c791c1bb489dbdfe 100644
--- a/util/win/exception_handler_server.cc
+++ b/util/win/exception_handler_server.cc
@@ -317,6 +317,12 @@ bool ExceptionHandlerServer::ServiceClientConnection(
return false;
}
+ if (message.registration.version != RegistrationRequest::kMessageVersion) {
+ LOG(ERROR) << "unexpected version. got: " << message.registration.version
+ << " expecting: " << RegistrationRequest::kMessageVersion;
+ return false;
+ }
+
decltype(GetNamedPipeClientProcessId)* get_named_pipe_client_process_id =
GetNamedPipeClientProcessIdFunction();
if (get_named_pipe_client_process_id) {
« no previous file with comments | « client/crashpad_client_win.cc ('k') | util/win/registration_protocol_win.h » ('j') | util/win/registration_protocol_win.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698