runtime/vm/gc_marker.cc - Issue 1314673008: Migrate logging infrastructure Isolate->Thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/gc_marker.cc

Issue 1314673008: Migrate logging infrastructure Isolate->Thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Finalize marking tasks in parallel, now that it's safe. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/gc_marker.cc

diff --git a/runtime/vm/gc_marker.cc b/runtime/vm/gc_marker.cc

index 42a08bd6e7c3126aecd2abf7f66b4fe04f20b30e..a03d3b21f18ac1a2233b3d8f4cb8046ed202a09e 100644

--- a/runtime/vm/gc_marker.cc

+++ b/runtime/vm/gc_marker.cc

@@ -700,11 +700,9 @@ void GCMarker::MarkObjects(Isolate* isolate,

MarkingWeakVisitor mark_weak;

IterateWeakRoots(isolate, &mark_weak,

!visit_prologue_weak_persistent_handles);

- // TODO(koda): Move this into Phase 3 after making ISL_Print thread-safe

- // (used in SkippedCodeFunctions::DetachCode).

- FinalizeResultsFrom(&mark);

MainSync(num_tasks);

// Phase 3: Finalize results from all markers (detach code, etc.).

+ FinalizeResultsFrom(&mark);

MainSync(num_tasks);

// Finalization complete and all tasks exited.

}