Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1314673007: CREDENTIAL: Update PasswordCredential's constructor. (Closed)

Created:
5 years, 3 months ago by Mike West
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CREDENTIAL: Update PasswordCredential's constructor. Rather than a list of parameters, PasswordCredential is defined[1] to take a PasswordCredentialData object. We defined that object long ago (in [2]), but apparently never actually used it. This patch fixes that oversight. As a drive-by, this patch also stops exposing the PasswordCredential and FederatedCredential to Workers, as per spec. [1]: https://w3c.github.io/webappsec/specs/credentialmanagement/#interfaces-credential-types-passwordcredential [2]: https://codereview.chromium.org/1162883002 BUG=494880 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201723

Patch Set 1 #

Patch Set 2 : Ugh. Missed one. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -28 lines) Patch
M LayoutTests/http/tests/credentialmanager/credentialscontainer-store-basics.html View 1 chunk +11 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html View 1 5 chunks +29 lines, -6 lines 0 comments Download
M Source/modules/credentialmanager/Credential.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/credentialmanager/FederatedCredential.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/credentialmanager/PasswordCredential.h View 1 chunk +2 lines, -11 lines 0 comments Download
M Source/modules/credentialmanager/PasswordCredential.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/credentialmanager/PasswordCredential.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
Mike West
Vaclav, Philip, would one of you mind taking a look at this small CL? We ...
5 years, 3 months ago (2015-09-03 10:44:26 UTC) #2
vabr (Chromium)
On 2015/09/03 10:44:26, Mike West (buried) wrote: > Vaclav, Philip, would one of you mind ...
5 years, 3 months ago (2015-09-03 10:50:20 UTC) #3
Mike West
On 2015/09/03 at 10:50:20, vabr wrote: > On 2015/09/03 10:44:26, Mike West (buried) wrote: > ...
5 years, 3 months ago (2015-09-03 11:12:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314673007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314673007/1
5 years, 3 months ago (2015-09-03 11:12:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314673007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314673007/20001
5 years, 3 months ago (2015-09-03 11:23:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/96114)
5 years, 3 months ago (2015-09-03 11:26:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314673007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314673007/40001
5 years, 3 months ago (2015-09-03 11:45:58 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/48695)
5 years, 3 months ago (2015-09-03 12:54:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314673007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314673007/40001
5 years, 3 months ago (2015-09-03 13:02:06 UTC) #18
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 14:08:46 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201723

Powered by Google App Engine
This is Rietveld 408576698