Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1314633002: Update giflib to 5.1.1 (AOSP hash) (Closed)

Created:
5 years, 4 months ago by msarett
Modified:
5 years, 4 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update giflib to 5.1.1 (AOSP hash) This also disables warnings in giflib and fixes compile warnings in icu, in order to fix a skia bug. BUG=skia:4220 Committed: https://skia.googlesource.com/skia/+/0e6ff3882df3e5658a86124fe7889944b6735140

Patch Set 1 #

Patch Set 2 : Test #

Patch Set 3 : Disable specific warnings on win #

Patch Set 4 : Icu test #

Patch Set 5 : icu test 2 #

Patch Set 6 : Icu fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gyp/giflib.gyp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M gyp/icu.gyp View 1 2 3 4 5 1 chunk +17 lines, -3 lines 0 comments Download
M src/codec/SkCodec_libgif.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1188223002 Patch 1

Messages

Total messages: 29 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314633002/1
5 years, 4 months ago (2015-08-24 13:28:00 UTC) #2
msarett
Won't land until we're sure that Android has settled down.
5 years, 4 months ago (2015-08-24 13:28:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-24 13:33:49 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314633002/20001
5 years, 4 months ago (2015-08-24 16:38:55 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-24 16:43:55 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314633002/40001
5 years, 4 months ago (2015-08-24 16:52:28 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314633002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314633002/60001
5 years, 4 months ago (2015-08-24 16:57:45 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-24 17:03:40 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314633002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314633002/80001
5 years, 4 months ago (2015-08-24 17:32:43 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/2918)
5 years, 4 months ago (2015-08-24 17:37:14 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314633002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314633002/90001
5 years, 4 months ago (2015-08-24 18:00:58 UTC) #22
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-24 18:06:29 UTC) #24
msarett
I think this is safe to land now? Along with the giflib update I've included ...
5 years, 4 months ago (2015-08-24 18:12:30 UTC) #25
djsollen
lgtm
5 years, 4 months ago (2015-08-24 18:58:00 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314633002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314633002/90001
5 years, 4 months ago (2015-08-24 18:59:35 UTC) #28
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 19:00:18 UTC) #29
Message was sent while issue was closed. 
Committed patchset #6 (id:90001) as
https://skia.googlesource.com/skia/+/0e6ff3882df3e5658a86124fe7889944b6735140

Powered by Google App Engine
This is Rietveld 408576698