Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1314623002: Make Simulator respect C stack limits as well. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
mvstanton, Yang
CC:
v8-dev, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make Simulator respect C stack limits as well. The simulator uses a separate JS stack, exhaustion of the C stack however is not caught by JS limit checks. This change now lowers the limit of the JS stack accordingly on function calls. R=mvstanton@chromium.org BUG=chromium:522380 TEST=mjsunit/regress/regress-crbug-522380 LOG=n Committed: https://crrev.com/7fb31bdba4f2a0320507956a085f083d76bce48c Cr-Commit-Position: refs/heads/master@{#30334}

Patch Set 1 #

Patch Set 2 : Architecture ports.wq #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -49 lines) Patch
M src/arm/simulator-arm.h View 1 2 chunks +6 lines, -7 lines 1 comment Download
M src/arm/simulator-arm.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M src/arm64/simulator-arm64.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M src/execution.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/execution.cc View 2 chunks +21 lines, -8 lines 0 comments Download
M src/mips/simulator-mips.h View 1 2 chunks +6 lines, -7 lines 0 comments Download
M src/mips/simulator-mips.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
M src/mips64/simulator-mips64.h View 1 2 chunks +6 lines, -7 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 1 2 chunks +12 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-522380.js View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Michael Starzinger
Yang: Not sure when Michael will be back, could you PTAL in the meantime? Thanks! ...
5 years, 4 months ago (2015-08-24 13:46:31 UTC) #3
Yang
lgtm.
5 years, 4 months ago (2015-08-24 15:36:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314623002/20001
5 years, 4 months ago (2015-08-24 15:54:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-24 15:55:36 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7fb31bdba4f2a0320507956a085f083d76bce48c Cr-Commit-Position: refs/heads/master@{#30334}
5 years, 4 months ago (2015-08-24 15:55:48 UTC) #8
mvstanton
5 years, 4 months ago (2015-08-25 07:49:41 UTC) #9
Message was sent while issue was closed.
An ingenious solution!
LGTM.

Powered by Google App Engine
This is Rietveld 408576698