chrome/test/chromedriver/session_commands.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/session_commands.cc

diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc

index 8fdea230c7e461a523bac2e488c3c150b4c2ae88..4be22c4a4700648e7c751ab0838d828a9c5a9c84 100644

--- a/chrome/test/chromedriver/session_commands.cc

+++ b/chrome/test/chromedriver/session_commands.cc

@@ -201,7 +201,8 @@ Status ExecuteSwitchToWindow(

status = web_view->ConnectIfNecessary();

if (status.IsError())

return status;

- status = web_view->CallFunction("", kGetWindowNameScript, args, &result);

+ status = web_view->CallFunction(

+ std::string(), kGetWindowNameScript, args, &result);

if (status.IsError())

return status;

std::string window_name;

« no previous file with comments | « chrome/test/chromedriver/session.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »