Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/window_commands.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/session_commands.cc ('k') | chrome/test/gpu/gpu_pixel_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/window_commands.cc
diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc
index 557d572832174009c70bf029c57fa8eb17838719..e7b7cd18caf4c4b4268b94f5f15db0ab8f708948 100644
--- a/chrome/test/chromedriver/window_commands.cc
+++ b/chrome/test/chromedriver/window_commands.cc
@@ -347,7 +347,8 @@ Status ExecuteGoBack(
WebView* web_view,
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value) {
- return web_view->EvaluateScript("", "window.history.back();", value);
+ return web_view->EvaluateScript(
+ std::string(), "window.history.back();", value);
}
Status ExecuteGoForward(
@@ -355,7 +356,8 @@ Status ExecuteGoForward(
WebView* web_view,
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value) {
- return web_view->EvaluateScript("", "window.history.forward();", value);
+ return web_view->EvaluateScript(
+ std::string(), "window.history.forward();", value);
}
Status ExecuteRefresh(
« no previous file with comments | « chrome/test/chromedriver/session_commands.cc ('k') | chrome/test/gpu/gpu_pixel_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698