Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/browser/search/search_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search/search_unittest.cc
diff --git a/chrome/browser/search/search_unittest.cc b/chrome/browser/search/search_unittest.cc
index 90ff642ba658f206c32d4ac1d0d2109abf88a9dd..7c4bf4cb654823196b6491a5021b5f3f354894c0 100644
--- a/chrome/browser/search/search_unittest.cc
+++ b/chrome/browser/search/search_unittest.cc
@@ -22,7 +22,7 @@ TEST(EmbeddedSearchFieldTrialTest, GetFieldTrialInfo) {
uint64 group_number = 0;
const uint64 ZERO = 0;
- EXPECT_FALSE(GetFieldTrialInfo("", &flags, &group_number));
+ EXPECT_FALSE(GetFieldTrialInfo(std::string(), &flags, &group_number));
EXPECT_EQ(ZERO, group_number);
EXPECT_EQ(ZERO, flags.size());
@@ -62,9 +62,10 @@ TEST(EmbeddedSearchFieldTrialTest, GetFieldTrialInfo) {
EXPECT_EQ(uint64(3), flags.size());
EXPECT_EQ(true, GetBoolValueForFlagWithDefault("bar", false, flags));
EXPECT_EQ(uint64(7), GetUInt64ValueForFlagWithDefault("baz", 0, flags));
- EXPECT_EQ("dogs", GetStringValueForFlagWithDefault("cat", "", flags));
- EXPECT_EQ("default", GetStringValueForFlagWithDefault(
- "moose", "default", flags));
+ EXPECT_EQ("dogs",
+ GetStringValueForFlagWithDefault("cat", std::string(), flags));
+ EXPECT_EQ("default",
+ GetStringValueForFlagWithDefault("moose", "default", flags));
group_number = 0;
flags.clear();
« no previous file with comments | « chrome/browser/search/search.cc ('k') | chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698