Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: chrome/browser/search/search_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/prefs/pref_service.h" 6 #include "base/prefs/pref_service.h"
7 #include "chrome/browser/search/search.h" 7 #include "chrome/browser/search/search.h"
8 #include "chrome/browser/search_engines/template_url_service.h" 8 #include "chrome/browser/search_engines/template_url_service.h"
9 #include "chrome/browser/search_engines/template_url_service_factory.h" 9 #include "chrome/browser/search_engines/template_url_service_factory.h"
10 #include "chrome/browser/ui/tabs/tab_strip_model.h" 10 #include "chrome/browser/ui/tabs/tab_strip_model.h"
11 #include "chrome/common/chrome_switches.h" 11 #include "chrome/common/chrome_switches.h"
12 #include "chrome/common/pref_names.h" 12 #include "chrome/common/pref_names.h"
13 #include "chrome/common/url_constants.h" 13 #include "chrome/common/url_constants.h"
14 #include "chrome/test/base/browser_with_test_window_test.h" 14 #include "chrome/test/base/browser_with_test_window_test.h"
15 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
16 #include "content/public/browser/web_contents.h" 16 #include "content/public/browser/web_contents.h"
17 17
18 namespace chrome { 18 namespace chrome {
19 19
20 TEST(EmbeddedSearchFieldTrialTest, GetFieldTrialInfo) { 20 TEST(EmbeddedSearchFieldTrialTest, GetFieldTrialInfo) {
21 FieldTrialFlags flags; 21 FieldTrialFlags flags;
22 uint64 group_number = 0; 22 uint64 group_number = 0;
23 const uint64 ZERO = 0; 23 const uint64 ZERO = 0;
24 24
25 EXPECT_FALSE(GetFieldTrialInfo("", &flags, &group_number)); 25 EXPECT_FALSE(GetFieldTrialInfo(std::string(), &flags, &group_number));
26 EXPECT_EQ(ZERO, group_number); 26 EXPECT_EQ(ZERO, group_number);
27 EXPECT_EQ(ZERO, flags.size()); 27 EXPECT_EQ(ZERO, flags.size());
28 28
29 EXPECT_TRUE(GetFieldTrialInfo("Group77", &flags, &group_number)); 29 EXPECT_TRUE(GetFieldTrialInfo("Group77", &flags, &group_number));
30 EXPECT_EQ(uint64(77), group_number); 30 EXPECT_EQ(uint64(77), group_number);
31 EXPECT_EQ(ZERO, flags.size()); 31 EXPECT_EQ(ZERO, flags.size());
32 32
33 group_number = 0; 33 group_number = 0;
34 EXPECT_FALSE(GetFieldTrialInfo("Group77.2", &flags, &group_number)); 34 EXPECT_FALSE(GetFieldTrialInfo("Group77.2", &flags, &group_number));
35 EXPECT_EQ(ZERO, group_number); 35 EXPECT_EQ(ZERO, group_number);
(...skipping 19 matching lines...) Expand all
55 EXPECT_EQ(uint64(6), GetUInt64ValueForFlagWithDefault("foo", 9999, flags)); 55 EXPECT_EQ(uint64(6), GetUInt64ValueForFlagWithDefault("foo", 9999, flags));
56 56
57 group_number = 0; 57 group_number = 0;
58 flags.clear(); 58 flags.clear();
59 EXPECT_TRUE(GetFieldTrialInfo( 59 EXPECT_TRUE(GetFieldTrialInfo(
60 "Group77 bar:1 baz:7 cat:dogs", &flags, &group_number)); 60 "Group77 bar:1 baz:7 cat:dogs", &flags, &group_number));
61 EXPECT_EQ(uint64(77), group_number); 61 EXPECT_EQ(uint64(77), group_number);
62 EXPECT_EQ(uint64(3), flags.size()); 62 EXPECT_EQ(uint64(3), flags.size());
63 EXPECT_EQ(true, GetBoolValueForFlagWithDefault("bar", false, flags)); 63 EXPECT_EQ(true, GetBoolValueForFlagWithDefault("bar", false, flags));
64 EXPECT_EQ(uint64(7), GetUInt64ValueForFlagWithDefault("baz", 0, flags)); 64 EXPECT_EQ(uint64(7), GetUInt64ValueForFlagWithDefault("baz", 0, flags));
65 EXPECT_EQ("dogs", GetStringValueForFlagWithDefault("cat", "", flags)); 65 EXPECT_EQ("dogs",
66 EXPECT_EQ("default", GetStringValueForFlagWithDefault( 66 GetStringValueForFlagWithDefault("cat", std::string(), flags));
67 "moose", "default", flags)); 67 EXPECT_EQ("default",
68 GetStringValueForFlagWithDefault("moose", "default", flags));
68 69
69 group_number = 0; 70 group_number = 0;
70 flags.clear(); 71 flags.clear();
71 EXPECT_FALSE(GetFieldTrialInfo( 72 EXPECT_FALSE(GetFieldTrialInfo(
72 "Group77 bar:1 baz:7 cat:dogs DISABLED", &flags, &group_number)); 73 "Group77 bar:1 baz:7 cat:dogs DISABLED", &flags, &group_number));
73 EXPECT_EQ(ZERO, group_number); 74 EXPECT_EQ(ZERO, group_number);
74 EXPECT_EQ(ZERO, flags.size()); 75 EXPECT_EQ(ZERO, flags.size());
75 } 76 }
76 77
77 class SearchTest : public BrowserWithTestWindowTest { 78 class SearchTest : public BrowserWithTestWindowTest {
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 profile()->GetPrefs()->SetBoolean(prefs::kInstantEnabled, true); 324 profile()->GetPrefs()->SetBoolean(prefs::kInstantEnabled, true);
324 EXPECT_EQ(GURL("http://foo.com/instant?foo=foo#foo=foo"), 325 EXPECT_EQ(GURL("http://foo.com/instant?foo=foo#foo=foo"),
325 GetInstantURL(profile(), kDisableStartMargin)); 326 GetInstantURL(profile(), kDisableStartMargin));
326 327
327 // With start margin. 328 // With start margin.
328 EXPECT_EQ(GURL("http://foo.com/instant?es_sm=10&foo=foo#foo=foo"), 329 EXPECT_EQ(GURL("http://foo.com/instant?es_sm=10&foo=foo#foo=foo"),
329 GetInstantURL(profile(), 10)); 330 GetInstantURL(profile(), 10));
330 } 331 }
331 332
332 } // namespace chrome 333 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/search/search.cc ('k') | chrome/browser/search_engines/template_url_prepopulate_data_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698