chrome/service/service_process_prefs_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/service_process_prefs_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/service/service_process_prefs_unittest.cc

diff --git a/chrome/service/service_process_prefs_unittest.cc b/chrome/service/service_process_prefs_unittest.cc

index 5d68ab31d17ac482801ce2b89ee1dae75e44ac9f..3d7ae1fee09a4123e18d971bd51877e528acbe70 100644

--- a/chrome/service/service_process_prefs_unittest.cc

+++ b/chrome/service/service_process_prefs_unittest.cc

@@ -39,9 +39,8 @@ TEST_F(ServiceProcessPrefsTest, RetrievePrefs) {

prefs_->WritePrefs();

message_loop_.RunUntilIdle();

prefs_->SetBoolean("testb", false); // overwrite

- prefs_->SetString("tests", ""); // overwrite

+ prefs_->SetString("tests", std::string()); // overwrite

prefs_->ReadPrefs();

EXPECT_EQ(prefs_->GetBoolean("testb", false), true);

- EXPECT_EQ(prefs_->GetString("tests", ""), "testvalue");

+ EXPECT_EQ(prefs_->GetString("tests", std::string()), "testvalue");

}

« no previous file with comments | « chrome/service/service_process.cc ('k') | chrome/test/base/ui_test_utils.cc » ('j') | no next file with comments »