chrome/service/service_process_prefs_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/service/service_process_prefs_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/service/service_process.cc ('k') | chrome/test/base/ui_test_utils.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include <string>	5 #include <string>

6	6

7 #include "base/files/scoped_temp_dir.h"	7 #include "base/files/scoped_temp_dir.h"

8 #include "base/message_loop.h"	8 #include "base/message_loop.h"

9 #include "base/sequenced_task_runner.h"	9 #include "base/sequenced_task_runner.h"

10 #include "chrome/service/service_process_prefs.h"	10 #include "chrome/service/service_process_prefs.h"

(...skipping 21 matching lines...) Expand all Loading...
32 scoped_ptr<ServiceProcessPrefs> prefs_;	32 scoped_ptr<ServiceProcessPrefs> prefs_;

33 };	33 };

34	34

35 // Test ability to retrieve prefs	35 // Test ability to retrieve prefs

36 TEST_F(ServiceProcessPrefsTest, RetrievePrefs) {	36 TEST_F(ServiceProcessPrefsTest, RetrievePrefs) {

37 prefs_->SetBoolean("testb", true);	37 prefs_->SetBoolean("testb", true);

38 prefs_->SetString("tests", "testvalue");	38 prefs_->SetString("tests", "testvalue");

39 prefs_->WritePrefs();	39 prefs_->WritePrefs();

40 message_loop_.RunUntilIdle();	40 message_loop_.RunUntilIdle();

41 prefs_->SetBoolean("testb", false); // overwrite	41 prefs_->SetBoolean("testb", false); // overwrite

42 prefs_->SetString("tests", ""); // overwrite	42 prefs_->SetString("tests", std::string()); // overwrite

43 prefs_->ReadPrefs();	43 prefs_->ReadPrefs();

44 EXPECT_EQ(prefs_->GetBoolean("testb", false), true);	44 EXPECT_EQ(prefs_->GetBoolean("testb", false), true);

45 EXPECT_EQ(prefs_->GetString("tests", ""), "testvalue");	45 EXPECT_EQ(prefs_->GetString("tests", std::string()), "testvalue");

46 }	46 }

47

OLD	NEW