Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: chrome/browser/safe_browsing/malware_details.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/malware_details.cc
diff --git a/chrome/browser/safe_browsing/malware_details.cc b/chrome/browser/safe_browsing/malware_details.cc
index 41cf6904108f0acd5c31b8f0d3b6ff60ba97845b..7eb336db05923f4144c83a8c3b606671c93833b8 100644
--- a/chrome/browser/safe_browsing/malware_details.cc
+++ b/chrome/browser/safe_browsing/malware_details.cc
@@ -178,16 +178,16 @@ void MalwareDetails::StartCollection() {
}
// Add the nodes, starting from the page url.
- AddUrl(page_url, GURL(), "", NULL);
+ AddUrl(page_url, GURL(), std::string(), NULL);
// Add the resource_url and its original url, if non-empty and different.
if (!resource_.original_url.is_empty() &&
resource_.url != resource_.original_url) {
// Add original_url, as the parent of resource_url.
- AddUrl(resource_.original_url, GURL(), "", NULL);
- AddUrl(resource_.url, resource_.original_url, "", NULL);
+ AddUrl(resource_.original_url, GURL(), std::string(), NULL);
+ AddUrl(resource_.url, resource_.original_url, std::string(), NULL);
} else {
- AddUrl(resource_.url, GURL(), "", NULL);
+ AddUrl(resource_.url, GURL(), std::string(), NULL);
}
// Add the redirect urls, if non-empty. The redirect urls do not include the
@@ -201,13 +201,13 @@ void MalwareDetails::StartCollection() {
}
// Set the previous redirect url as the parent of the next one
for (unsigned int i = 0; i < resource_.redirect_urls.size(); ++i) {
- AddUrl(resource_.redirect_urls[i], parent_url, "", NULL);
+ AddUrl(resource_.redirect_urls[i], parent_url, std::string(), NULL);
parent_url = resource_.redirect_urls[i];
}
// Add the referrer url.
if (nav_entry && !referrer_url.is_empty()) {
- AddUrl(referrer_url, GURL(), "", NULL);
+ AddUrl(referrer_url, GURL(), std::string(), NULL);
}
// Get URLs of frames, scripts etc from the DOM.
@@ -287,7 +287,7 @@ void MalwareDetails::OnRedirectionCollectionReady() {
void MalwareDetails::AddRedirectUrlList(const std::vector<GURL>& urls) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
for (size_t i = 0; i < urls.size()-1; ++i) {
- AddUrl(urls[i], urls[i+1], "", NULL);
+ AddUrl(urls[i], urls[i + 1], std::string(), NULL);
}
}
« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service_unittest.cc ('k') | chrome/browser/safe_browsing/ping_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698