chrome/browser/safe_browsing/ping_manager.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/ping_manager.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/ping_manager.cc

diff --git a/chrome/browser/safe_browsing/ping_manager.cc b/chrome/browser/safe_browsing/ping_manager.cc

index 6e739857ab7606290f8ebffb3c22a02e46b42321..56580d00865259018d7b40945001ab63c27b696c 100644

--- a/chrome/browser/safe_browsing/ping_manager.cc

+++ b/chrome/browser/safe_browsing/ping_manager.cc

@@ -113,7 +113,7 @@ GURL SafeBrowsingPingManager::SafeBrowsingHitUrl(

threat_type == SB_THREAT_TYPE_BINARY_MALWARE_HASH ||

threat_type == SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL);

std::string url = SafeBrowsingProtocolManagerHelper::ComposeUrl(

- url_prefix_, "report", client_name_, version_, "");

+ url_prefix_, "report", client_name_, version_, std::string());

std::string threat_list = "none";

switch (threat_type) {

case SB_THREAT_TYPE_URL_MALWARE: