chrome/browser/logging_chrome_browsertest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/logging_chrome_browsertest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/logging_chrome_browsertest.cc

diff --git a/chrome/browser/logging_chrome_browsertest.cc b/chrome/browser/logging_chrome_browsertest.cc

index 9728fd35a70f98f20b0ea6a5b9308a530ee32237..df32456952cebb75de7716acc7e9c2694010a5b8 100644

--- a/chrome/browser/logging_chrome_browsertest.cc

+++ b/chrome/browser/logging_chrome_browsertest.cc

@@ -44,7 +44,7 @@ class ChromeLoggingTest : public testing::Test {

// Tests the log file name getter without an environment variable.

TEST_F(ChromeLoggingTest, LogFileName) {

- SaveEnvironmentVariable("");

+ SaveEnvironmentVariable(std::string());

base::FilePath filename = logging::GetLogFileName();

ASSERT_NE(base::FilePath::StringType::npos,