Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2339)

Unified Diff: chrome/browser/language_usage_metrics_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/logging_chrome_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/language_usage_metrics_unittest.cc
diff --git a/chrome/browser/language_usage_metrics_unittest.cc b/chrome/browser/language_usage_metrics_unittest.cc
index db6e987e919bee604e333293f55624e466cd7a3f..e007e70521431c5e373b697ab61f85ab0ee0f3a2 100644
--- a/chrome/browser/language_usage_metrics_unittest.cc
+++ b/chrome/browser/language_usage_metrics_unittest.cc
@@ -16,7 +16,7 @@ TEST(LanguageUsageMetricsTest, ParseAcceptLanguages) {
EXPECT_EQ(JAPANESE, *language_set.begin());
// Empty language.
- LanguageUsageMetrics::ParseAcceptLanguages("", &language_set);
+ LanguageUsageMetrics::ParseAcceptLanguages(std::string(), &language_set);
EXPECT_EQ(0U, language_set.size());
// Country code is ignored.
@@ -86,6 +86,6 @@ TEST(LanguageUsageMetricsTest, ToLanguage) {
EXPECT_EQ(JAPANESE, LanguageUsageMetrics::ToLanguage("ja-JP"));
// Invalid locales are considered as unknown language.
- EXPECT_EQ(UNKNOWN_LANGUAGE, LanguageUsageMetrics::ToLanguage(""));
+ EXPECT_EQ(UNKNOWN_LANGUAGE, LanguageUsageMetrics::ToLanguage(std::string()));
EXPECT_EQ(UNKNOWN_LANGUAGE, LanguageUsageMetrics::ToLanguage("xx"));
}
« no previous file with comments | « chrome/browser/io_thread.cc ('k') | chrome/browser/logging_chrome_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698