chrome/test/chromedriver/capabilities_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/capabilities_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/capabilities_unittest.cc

diff --git a/chrome/test/chromedriver/capabilities_unittest.cc b/chrome/test/chromedriver/capabilities_unittest.cc

index f6ac5ec052bb945d823327b6083af3aa350a55e9..9bf6c32477f5b009d7da353ce8771324986198bb 100644

--- a/chrome/test/chromedriver/capabilities_unittest.cc

+++ b/chrome/test/chromedriver/capabilities_unittest.cc

@@ -21,7 +21,7 @@ TEST(ParseCapabilities, WithAndroidPackage) {

TEST(ParseCapabilities, EmptyAndroidPackage) {

Capabilities capabilities;

base::DictionaryValue caps;

- caps.SetString("chromeOptions.android_package", "");

+ caps.SetString("chromeOptions.android_package", std::string());

Status status = capabilities.Parse(caps);

ASSERT_FALSE(status.IsOk());

}