Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: chrome/test/chromedriver/capabilities_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/capabilities.h" 5 #include "chrome/test/chromedriver/capabilities.h"
6 6
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/test/chromedriver/chrome/status.h" 8 #include "chrome/test/chromedriver/chrome/status.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 TEST(ParseCapabilities, WithAndroidPackage) { 11 TEST(ParseCapabilities, WithAndroidPackage) {
12 Capabilities capabilities; 12 Capabilities capabilities;
13 base::DictionaryValue caps; 13 base::DictionaryValue caps;
14 caps.SetString("chromeOptions.android_package", "abc"); 14 caps.SetString("chromeOptions.android_package", "abc");
15 Status status = capabilities.Parse(caps); 15 Status status = capabilities.Parse(caps);
16 ASSERT_TRUE(status.IsOk()); 16 ASSERT_TRUE(status.IsOk());
17 ASSERT_TRUE(capabilities.IsAndroid()); 17 ASSERT_TRUE(capabilities.IsAndroid());
18 ASSERT_EQ("abc", capabilities.android_package); 18 ASSERT_EQ("abc", capabilities.android_package);
19 } 19 }
20 20
21 TEST(ParseCapabilities, EmptyAndroidPackage) { 21 TEST(ParseCapabilities, EmptyAndroidPackage) {
22 Capabilities capabilities; 22 Capabilities capabilities;
23 base::DictionaryValue caps; 23 base::DictionaryValue caps;
24 caps.SetString("chromeOptions.android_package", ""); 24 caps.SetString("chromeOptions.android_package", std::string());
25 Status status = capabilities.Parse(caps); 25 Status status = capabilities.Parse(caps);
26 ASSERT_FALSE(status.IsOk()); 26 ASSERT_FALSE(status.IsOk());
27 } 27 }
28 28
29 TEST(ParseCapabilities, IllegalAndroidPackage) { 29 TEST(ParseCapabilities, IllegalAndroidPackage) {
30 Capabilities capabilities; 30 Capabilities capabilities;
31 base::DictionaryValue caps; 31 base::DictionaryValue caps;
32 caps.SetInteger("chromeOptions.android_package", 123); 32 caps.SetInteger("chromeOptions.android_package", 123);
33 Status status = capabilities.Parse(caps); 33 Status status = capabilities.Parse(caps);
34 ASSERT_FALSE(status.IsOk()); 34 ASSERT_FALSE(status.IsOk());
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 245
246 TEST(ParseCapabilities, MissingSettingForManualProxy) { 246 TEST(ParseCapabilities, MissingSettingForManualProxy) {
247 Capabilities capabilities; 247 Capabilities capabilities;
248 base::DictionaryValue proxy; 248 base::DictionaryValue proxy;
249 proxy.SetString("proxyType", "manual"); 249 proxy.SetString("proxyType", "manual");
250 base::DictionaryValue caps; 250 base::DictionaryValue caps;
251 caps.Set("proxy", proxy.DeepCopy()); 251 caps.Set("proxy", proxy.DeepCopy());
252 Status status = capabilities.Parse(caps); 252 Status status = capabilities.Parse(caps);
253 ASSERT_FALSE(status.IsOk()); 253 ASSERT_FALSE(status.IsOk());
254 } 254 }
OLDNEW
« no previous file with comments | « chrome/test/base/ui_test_utils.cc ('k') | chrome/test/chromedriver/chrome/automation_extension.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698