net/spdy/spdy_http_utils.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_http_utils.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_http_utils.cc

diff --git a/net/spdy/spdy_http_utils.cc b/net/spdy/spdy_http_utils.cc

index 41647c1729fc26c920374e564de118c34c59c007..49fb8ca32b5c7676aedcd09fc6d5bcd883301bf3 100644

--- a/net/spdy/spdy_http_utils.cc

+++ b/net/spdy/spdy_http_utils.cc

@@ -188,8 +188,9 @@ GURL GetUrlFromHeaderBlock(const SpdyHeaderBlock& headers,

if (it != headers.end())

path = it->second;

- std::string url = (scheme.empty() || host_port.empty() || path.empty())

- ? "" : scheme + "://" + host_port + path;

+ std::string url = (scheme.empty() || host_port.empty() || path.empty())

+ ? std::string()

+ : scheme + "://" + host_port + path;

return GURL(url);

}

« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/spdy/spdy_session_spdy2_unittest.cc » ('j') | no next file with comments »