net/spdy/spdy_framer_test.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_framer_test.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_framer_test.cc

diff --git a/net/spdy/spdy_framer_test.cc b/net/spdy/spdy_framer_test.cc

index 46d44c98cea10bb1d99fad2e72af719d3a02cfa4..3ae8871a49f64796da9001fb99bed5cd3b4a46a8 100644

--- a/net/spdy/spdy_framer_test.cc

+++ b/net/spdy/spdy_framer_test.cc

@@ -1826,7 +1826,7 @@ TEST_P(SpdyFramerTest, CreateSynStreamUncompressed) {

"max stream ID";

SpdyHeaderBlock headers;

- headers[""] = "foo";

+ headers[std::string()] = "foo";

headers["foo"] = "bar";

const unsigned char kV2FrameData[] = {

@@ -2103,7 +2103,7 @@ TEST_P(SpdyFramerTest, CreateSynReplyUncompressed) {

"SYN_REPLY frame with a 0-length header name, FIN, max stream ID";

SpdyHeaderBlock headers;

- headers[""] = "foo";

+ headers[std::string()] = "foo";

headers["foo"] = "bar";

const unsigned char kV2FrameData[] = {

@@ -2619,7 +2619,7 @@ TEST_P(SpdyFramerTest, CreateHeadersUncompressed) {

"HEADERS frame with a 0-length header name, FIN, max stream ID";

SpdyHeaderBlock headers;

- headers[""] = "foo";

+ headers[std::string()] = "foo";

headers["foo"] = "bar";

const unsigned char kV2FrameData[] = {

« no previous file with comments | « net/socket/transport_client_socket_pool_unittest.cc ('k') | net/spdy/spdy_http_utils.cc » ('j') | no next file with comments »