Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1862)

Unified Diff: base/test/trace_event_analyzer_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/trace_event_analyzer.cc ('k') | base/values_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/trace_event_analyzer_unittest.cc
diff --git a/base/test/trace_event_analyzer_unittest.cc b/base/test/trace_event_analyzer_unittest.cc
index 33cacbff74e3c0ea13c07d42880b2d250b6ec8f6..52926fd7b9f7e16e9a2d2a29d4d07de87086064f 100644
--- a/base/test/trace_event_analyzer_unittest.cc
+++ b/base/test/trace_event_analyzer_unittest.cc
@@ -786,7 +786,7 @@ TEST_F(TraceEventAnalyzerTest, FindClosest) {
events[0].name = "one";
events[2].name = "two";
events[4].name = "three";
- Query query_named = Query::EventName() != Query::String("");
+ Query query_named = Query::EventName() != Query::String(std::string());
Query query_one = Query::EventName() == Query::String("one");
// Only one event matches query_one, so two closest can't be found.
@@ -822,7 +822,7 @@ TEST_F(TraceEventAnalyzerTest, CountMatches) {
events[0].name = "one";
events[2].name = "two";
events[4].name = "three";
- Query query_named = Query::EventName() != Query::String("");
+ Query query_named = Query::EventName() != Query::String(std::string());
Query query_one = Query::EventName() == Query::String("one");
EXPECT_EQ(0u, CountMatches(event_ptrs, Query::Bool(false)));
« no previous file with comments | « base/test/trace_event_analyzer.cc ('k') | base/values_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698