Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: base/test/trace_event_analyzer_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/test/trace_event_analyzer.cc ('k') | base/values_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/debug/trace_event_unittest.h" 6 #include "base/debug/trace_event_unittest.h"
7 #include "base/test/trace_event_analyzer.h" 7 #include "base/test/trace_event_analyzer.h"
8 #include "testing/gmock/include/gmock/gmock.h" 8 #include "testing/gmock/include/gmock/gmock.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 768 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 events.resize(num_events); 779 events.resize(num_events);
780 for (size_t i = 0; i < events.size(); ++i) { 780 for (size_t i = 0; i < events.size(); ++i) {
781 // timestamps go up exponentially so the lower index is always closer in 781 // timestamps go up exponentially so the lower index is always closer in
782 // time than the higher index. 782 // time than the higher index.
783 events[i].timestamp = static_cast<double>(i) * static_cast<double>(i); 783 events[i].timestamp = static_cast<double>(i) * static_cast<double>(i);
784 event_ptrs.push_back(&events[i]); 784 event_ptrs.push_back(&events[i]);
785 } 785 }
786 events[0].name = "one"; 786 events[0].name = "one";
787 events[2].name = "two"; 787 events[2].name = "two";
788 events[4].name = "three"; 788 events[4].name = "three";
789 Query query_named = Query::EventName() != Query::String(""); 789 Query query_named = Query::EventName() != Query::String(std::string());
790 Query query_one = Query::EventName() == Query::String("one"); 790 Query query_one = Query::EventName() == Query::String("one");
791 791
792 // Only one event matches query_one, so two closest can't be found. 792 // Only one event matches query_one, so two closest can't be found.
793 EXPECT_FALSE(FindClosest(event_ptrs, query_one, 0, &index_1, &index_2)); 793 EXPECT_FALSE(FindClosest(event_ptrs, query_one, 0, &index_1, &index_2));
794 794
795 EXPECT_TRUE(FindClosest(event_ptrs, query_one, 3, &index_1, NULL)); 795 EXPECT_TRUE(FindClosest(event_ptrs, query_one, 3, &index_1, NULL));
796 EXPECT_EQ(0u, index_1); 796 EXPECT_EQ(0u, index_1);
797 797
798 EXPECT_TRUE(FindClosest(event_ptrs, query_named, 1, &index_1, &index_2)); 798 EXPECT_TRUE(FindClosest(event_ptrs, query_named, 1, &index_1, &index_2));
799 EXPECT_EQ(0u, index_1); 799 EXPECT_EQ(0u, index_1);
(...skipping 15 matching lines...) Expand all
815 815
816 size_t num_events = 5; 816 size_t num_events = 5;
817 size_t num_named = 3; 817 size_t num_named = 3;
818 std::vector<TraceEvent> events; 818 std::vector<TraceEvent> events;
819 events.resize(num_events); 819 events.resize(num_events);
820 for (size_t i = 0; i < events.size(); ++i) 820 for (size_t i = 0; i < events.size(); ++i)
821 event_ptrs.push_back(&events[i]); 821 event_ptrs.push_back(&events[i]);
822 events[0].name = "one"; 822 events[0].name = "one";
823 events[2].name = "two"; 823 events[2].name = "two";
824 events[4].name = "three"; 824 events[4].name = "three";
825 Query query_named = Query::EventName() != Query::String(""); 825 Query query_named = Query::EventName() != Query::String(std::string());
826 Query query_one = Query::EventName() == Query::String("one"); 826 Query query_one = Query::EventName() == Query::String("one");
827 827
828 EXPECT_EQ(0u, CountMatches(event_ptrs, Query::Bool(false))); 828 EXPECT_EQ(0u, CountMatches(event_ptrs, Query::Bool(false)));
829 EXPECT_EQ(num_events, CountMatches(event_ptrs, Query::Bool(true))); 829 EXPECT_EQ(num_events, CountMatches(event_ptrs, Query::Bool(true)));
830 EXPECT_EQ(num_events - 1, CountMatches(event_ptrs, Query::Bool(true), 830 EXPECT_EQ(num_events - 1, CountMatches(event_ptrs, Query::Bool(true),
831 1, num_events)); 831 1, num_events));
832 EXPECT_EQ(1u, CountMatches(event_ptrs, query_one)); 832 EXPECT_EQ(1u, CountMatches(event_ptrs, query_one));
833 EXPECT_EQ(num_events - 1, CountMatches(event_ptrs, !query_one)); 833 EXPECT_EQ(num_events - 1, CountMatches(event_ptrs, !query_one));
834 EXPECT_EQ(num_named, CountMatches(event_ptrs, query_named)); 834 EXPECT_EQ(num_named, CountMatches(event_ptrs, query_named));
835 } 835 }
836 836
837 837
838 } // namespace trace_analyzer 838 } // namespace trace_analyzer
OLDNEW
« no previous file with comments | « base/test/trace_event_analyzer.cc ('k') | base/values_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698