Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: net/http/http_util_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/http/http_vary_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_util_unittest.cc
diff --git a/net/http/http_util_unittest.cc b/net/http/http_util_unittest.cc
index 083343dc5c5c92919d94bc6d310464c17e548c7b..f86821c450a60d16a607e308b546e63c96ffb6b5 100644
--- a/net/http/http_util_unittest.cc
+++ b/net/http/http_util_unittest.cc
@@ -966,12 +966,12 @@ TEST(HttpUtilTest, NameValuePairsIteratorCopyAndAssign) {
}
TEST(HttpUtilTest, NameValuePairsIteratorEmptyInput) {
- std::string data = "";
+ std::string data;
HttpUtil::NameValuePairsIterator parser(data.begin(), data.end(), ';');
EXPECT_TRUE(parser.valid());
- ASSERT_NO_FATAL_FAILURE(
- CheckNextNameValuePair(&parser, false, true, "", ""));
+ ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+ &parser, false, true, std::string(), std::string()));
}
TEST(HttpUtilTest, NameValuePairsIterator) {
@@ -997,19 +997,19 @@ TEST(HttpUtilTest, NameValuePairsIterator) {
ASSERT_NO_FATAL_FAILURE(
CheckNextNameValuePair(&parser, true, true, "f", "'hello world'"));
ASSERT_NO_FATAL_FAILURE(
- CheckNextNameValuePair(&parser, true, true, "g", ""));
+ CheckNextNameValuePair(&parser, true, true, "g", std::string()));
ASSERT_NO_FATAL_FAILURE(
CheckNextNameValuePair(&parser, true, true, "h", "hello"));
- ASSERT_NO_FATAL_FAILURE(
- CheckNextNameValuePair(&parser, false, true, "", ""));
+ ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+ &parser, false, true, std::string(), std::string()));
}
TEST(HttpUtilTest, NameValuePairsIteratorIllegalInputs) {
ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1", "; beta"));
- ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("", "beta"));
+ ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair(std::string(), "beta"));
ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1", "; 'beta'=2"));
- ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("", "'beta'=2"));
+ ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair(std::string(), "'beta'=2"));
ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1", ";beta="));
ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1",
";beta=;cappa=2"));
@@ -1033,8 +1033,8 @@ TEST(HttpUtilTest, NameValuePairsIteratorExtraSeparators) {
CheckNextNameValuePair(&parser, true, true, "beta", "2"));
ASSERT_NO_FATAL_FAILURE(
CheckNextNameValuePair(&parser, true, true, "cappa", "3"));
- ASSERT_NO_FATAL_FAILURE(
- CheckNextNameValuePair(&parser, false, true, "", ""));
+ ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+ &parser, false, true, std::string(), std::string()));
}
// See comments on the implementation of NameValuePairsIterator::GetNext
@@ -1046,6 +1046,6 @@ TEST(HttpUtilTest, NameValuePairsIteratorMissingEndQuote) {
ASSERT_NO_FATAL_FAILURE(
CheckNextNameValuePair(&parser, true, true, "name", "value"));
- ASSERT_NO_FATAL_FAILURE(
- CheckNextNameValuePair(&parser, false, true, "", ""));
+ ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+ &parser, false, true, std::string(), std::string()));
}
« no previous file with comments | « net/http/http_stream_factory_impl_unittest.cc ('k') | net/http/http_vary_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698