Rewrite std::string("") to std::string(), Linux edition.

net/http/http_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/basictypes.h"
 #include "base/string_util.h"
 #include "net/http/http_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 948 matching lines @@
       CheckCurrentNameValuePair(&parser_a, true, "beta", " b "));
 
   // advance b, no effect on a
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser_b, true, true, "cappa", "c;"));
   ASSERT_NO_FATAL_FAILURE(
       CheckCurrentNameValuePair(&parser_a, true, "beta", " b "));
 }
 
 TEST(HttpUtilTest, NameValuePairsIteratorEmptyInput) {
-  std::string data = "";
+  std::string data;
   HttpUtil::NameValuePairsIterator parser(data.begin(), data.end(), ';');
 
   EXPECT_TRUE(parser.valid());
-  ASSERT_NO_FATAL_FAILURE(
-      CheckNextNameValuePair(&parser, false, true, "", ""));
+  ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+      &parser, false, true, std::string(), std::string()));
 }
 
 TEST(HttpUtilTest, NameValuePairsIterator) {
   std::string data = "alpha=1; beta= 2 ;cappa =' 3; ';"
                      "delta= \" \\\"4\\\" \"; e= \" '5'\"; e=6;"
                      "f='\\'\\h\\e\\l\\l\\o\\ \\w\\o\\r\\l\\d\\'';"
                      "g=''; h='hello'";
   HttpUtil::NameValuePairsIterator parser(data.begin(), data.end(), ';');
   EXPECT_TRUE(parser.valid());
 
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "alpha", "1"));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "beta", "2"));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "cappa", " 3; "));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "delta", " \"4\" "));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "e", " '5'"));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "e", "6"));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "f", "'hello world'"));
   ASSERT_NO_FATAL_FAILURE(
-      CheckNextNameValuePair(&parser, true, true, "g", ""));
+      CheckNextNameValuePair(&parser, true, true, "g", std::string()));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "h", "hello"));
-  ASSERT_NO_FATAL_FAILURE(
-      CheckNextNameValuePair(&parser, false, true, "", ""));
+  ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+      &parser, false, true, std::string(), std::string()));
 }
 
 TEST(HttpUtilTest, NameValuePairsIteratorIllegalInputs) {
   ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1", "; beta"));
-  ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("", "beta"));
+  ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair(std::string(), "beta"));
 
   ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1", "; 'beta'=2"));
-  ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("", "'beta'=2"));
+  ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair(std::string(), "'beta'=2"));
   ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1", ";beta="));
   ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1",
                                                     ";beta=;cappa=2"));
 
   // According to the spec this is an error, but it doesn't seem appropriate to
   // change our behaviour to be less permissive at this time.
   // See NameValuePairsIteratorExtraSeparators test
   // ASSERT_NO_FATAL_FAILURE(CheckInvalidNameValuePair("alpha=1", ";; beta=2"));
 }
 
 // If we are going to support extra separators against the spec, let's just make
 // sure they work rationally.
 TEST(HttpUtilTest, NameValuePairsIteratorExtraSeparators) {
   std::string data = " ; ;;alpha=1; ;; ; beta= 2;cappa=3;;; ; ";
   HttpUtil::NameValuePairsIterator parser(data.begin(), data.end(), ';');
   EXPECT_TRUE(parser.valid());
 
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "alpha", "1"));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "beta", "2"));
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "cappa", "3"));
-  ASSERT_NO_FATAL_FAILURE(
-      CheckNextNameValuePair(&parser, false, true, "", ""));
+  ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+      &parser, false, true, std::string(), std::string()));
 }
 
 // See comments on the implementation of NameValuePairsIterator::GetNext
 // regarding this derogation from the spec.
 TEST(HttpUtilTest, NameValuePairsIteratorMissingEndQuote) {
   std::string data = "name='value";
   HttpUtil::NameValuePairsIterator parser(data.begin(), data.end(), ';');
   EXPECT_TRUE(parser.valid());
 
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "name", "value"));
-  ASSERT_NO_FATAL_FAILURE(
-      CheckNextNameValuePair(&parser, false, true, "", ""));
+  ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
+      &parser, false, true, std::string(), std::string()));
 }