Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Unified Diff: net/cookies/parsed_cookie_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/parsed_cookie.cc ('k') | net/dns/host_resolver_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/parsed_cookie_unittest.cc
diff --git a/net/cookies/parsed_cookie_unittest.cc b/net/cookies/parsed_cookie_unittest.cc
index 3729650292756f09778923ea1727c478e4c0a5d2..57de115a2796878359cb86edd30439f9d017aa7c 100644
--- a/net/cookies/parsed_cookie_unittest.cc
+++ b/net/cookies/parsed_cookie_unittest.cc
@@ -208,7 +208,7 @@ TEST(ParsedCookieTest, InvalidTooLong) {
}
TEST(ParsedCookieTest, InvalidEmpty) {
- ParsedCookie pc("");
+ ParsedCookie pc((std::string()));
EXPECT_FALSE(pc.IsValid());
}
@@ -259,7 +259,7 @@ TEST(ParsedCookieTest, SerializeCookieLine) {
TEST(ParsedCookieTest, SetNameAndValue) {
- ParsedCookie empty("");
+ ParsedCookie empty((std::string()));
EXPECT_FALSE(empty.IsValid());
EXPECT_FALSE(empty.SetDomain("foobar.com"));
EXPECT_TRUE(empty.SetName("name"));
@@ -282,7 +282,7 @@ TEST(ParsedCookieTest, SetNameAndValue) {
EXPECT_EQ("name=value", pc.ToCookieLine());
EXPECT_TRUE(pc.IsValid());
- EXPECT_FALSE(pc.SetName(""));
+ EXPECT_FALSE(pc.SetName(std::string()));
EXPECT_EQ("name=value", pc.ToCookieLine());
EXPECT_TRUE(pc.IsValid());
@@ -303,7 +303,7 @@ TEST(ParsedCookieTest, SetNameAndValue) {
EXPECT_EQ("test=\"foobar\"", pc.ToCookieLine());
EXPECT_TRUE(pc.IsValid());
- EXPECT_TRUE(pc.SetValue(""));
+ EXPECT_TRUE(pc.SetValue(std::string()));
EXPECT_EQ("test=", pc.ToCookieLine());
EXPECT_TRUE(pc.IsValid());
}
@@ -313,7 +313,7 @@ TEST(ParsedCookieTest, SetAttributes) {
EXPECT_TRUE(pc.IsValid());
// Clear an unset attribute.
- EXPECT_TRUE(pc.SetDomain(""));
+ EXPECT_TRUE(pc.SetDomain(std::string()));
EXPECT_FALSE(pc.HasDomain());
EXPECT_EQ("name=value", pc.ToCookieLine());
EXPECT_TRUE(pc.IsValid());
@@ -355,10 +355,10 @@ TEST(ParsedCookieTest, SetAttributes) {
pc.ToCookieLine());
// Clear the rest and change the name and value.
- EXPECT_TRUE(pc.SetDomain(""));
- EXPECT_TRUE(pc.SetPath(""));
- EXPECT_TRUE(pc.SetExpires(""));
- EXPECT_TRUE(pc.SetMaxAge(""));
+ EXPECT_TRUE(pc.SetDomain(std::string()));
+ EXPECT_TRUE(pc.SetPath(std::string()));
+ EXPECT_TRUE(pc.SetExpires(std::string()));
+ EXPECT_TRUE(pc.SetMaxAge(std::string()));
EXPECT_TRUE(pc.SetIsSecure(false));
EXPECT_TRUE(pc.SetIsHttpOnly(false));
EXPECT_TRUE(pc.SetName("name2"));
« no previous file with comments | « net/cookies/parsed_cookie.cc ('k') | net/dns/host_resolver_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698