Rewrite std::string("") to std::string(), Linux edition.

net/cookies/parsed_cookie_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "net/cookies/parsed_cookie.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
@@ skipping 190 matching lines @@
   maxstr.resize(ParsedCookie::kMaxCookieSize, 'a');
 
   ParsedCookie pc1(maxstr);
   EXPECT_TRUE(pc1.IsValid());
 
   ParsedCookie pc2(maxstr + "A");
   EXPECT_FALSE(pc2.IsValid());
 }
 
 TEST(ParsedCookieTest, InvalidEmpty) {
-  ParsedCookie pc("");
+  ParsedCookie pc((std::string()));
   EXPECT_FALSE(pc.IsValid());
 }
 
 TEST(ParsedCookieTest, EmbeddedTerminator) {
   ParsedCookie pc1("AAA=BB\0ZYX");
   ParsedCookie pc2("AAA=BB\rZYX");
   ParsedCookie pc3("AAA=BB\nZYX");
   EXPECT_TRUE(pc1.IsValid());
   EXPECT_EQ("AAA", pc1.Name());
   EXPECT_EQ("BB", pc1.Value());
@@ skipping 30 matching lines @@
                        "path=/  ;  ";
   const char output[] = "ANCUUID=zohNumRKgI0oxyhSsV3Z7D; "
                         "expires=Sun, 18-Apr-2027 21:06:29 GMT; "
                         "path=/";
   ParsedCookie pc(input);
   EXPECT_EQ(output, pc.ToCookieLine());
 }
 
 
 TEST(ParsedCookieTest, SetNameAndValue) {
-  ParsedCookie empty("");
+  ParsedCookie empty((std::string()));
   EXPECT_FALSE(empty.IsValid());
   EXPECT_FALSE(empty.SetDomain("foobar.com"));
   EXPECT_TRUE(empty.SetName("name"));
   EXPECT_TRUE(empty.SetValue("value"));
   EXPECT_EQ("name=value", empty.ToCookieLine());
   EXPECT_TRUE(empty.IsValid());
 
   // We don't test
   //   ParsedCookie invalid("@foo=bar");
   //   EXPECT_FALSE(invalid.IsValid());
   // here because we are slightly more tolerant to invalid cookie names and
   // values that are set by webservers. We only enforce a correct name and
   // value if set via SetName() and SetValue().
 
   ParsedCookie pc("name=value");
   EXPECT_TRUE(pc.IsValid());
 
   // Set invalid name / value.
   EXPECT_FALSE(pc.SetName("@foobar"));
   EXPECT_EQ("name=value", pc.ToCookieLine());
   EXPECT_TRUE(pc.IsValid());
 
-  EXPECT_FALSE(pc.SetName(""));
+  EXPECT_FALSE(pc.SetName(std::string()));
   EXPECT_EQ("name=value", pc.ToCookieLine());
   EXPECT_TRUE(pc.IsValid());
 
   EXPECT_FALSE(pc.SetValue("foo bar"));
   EXPECT_EQ("name=value", pc.ToCookieLine());
   EXPECT_TRUE(pc.IsValid());
 
   EXPECT_FALSE(pc.SetValue("\"foobar"));
   EXPECT_EQ("name=value", pc.ToCookieLine());
   EXPECT_TRUE(pc.IsValid());
 
   // Set valid name / value
   EXPECT_TRUE(pc.SetName("test"));
   EXPECT_EQ("test=value", pc.ToCookieLine());
   EXPECT_TRUE(pc.IsValid());
 
   EXPECT_TRUE(pc.SetValue("\"foobar\""));
   EXPECT_EQ("test=\"foobar\"", pc.ToCookieLine());
   EXPECT_TRUE(pc.IsValid());
 
-  EXPECT_TRUE(pc.SetValue(""));
+  EXPECT_TRUE(pc.SetValue(std::string()));
   EXPECT_EQ("test=", pc.ToCookieLine());
   EXPECT_TRUE(pc.IsValid());
 }
 
 TEST(ParsedCookieTest, SetAttributes) {
   ParsedCookie pc("name=value");
   EXPECT_TRUE(pc.IsValid());
 
   // Clear an unset attribute.
-  EXPECT_TRUE(pc.SetDomain(""));
+  EXPECT_TRUE(pc.SetDomain(std::string()));
   EXPECT_FALSE(pc.HasDomain());
   EXPECT_EQ("name=value", pc.ToCookieLine());
   EXPECT_TRUE(pc.IsValid());
 
   // Set a string containing an invalid character
   EXPECT_FALSE(pc.SetDomain("foo;bar"));
   EXPECT_FALSE(pc.HasDomain());
   EXPECT_EQ("name=value", pc.ToCookieLine());
   EXPECT_TRUE(pc.IsValid());
 
@@ skipping 21 matching lines @@
   EXPECT_TRUE(pc.HasPath());
   EXPECT_TRUE(pc.HasExpires());
   EXPECT_TRUE(pc.IsSecure());
   EXPECT_TRUE(pc.IsHttpOnly());
   EXPECT_EQ("name=value; domain=domain.com; path=/foo; "
             "expires=Sun, 18-Apr-2027 21:06:29 GMT; max-age=12345; secure; "
             "httponly",
             pc.ToCookieLine());
 
   // Clear the rest and change the name and value.
-  EXPECT_TRUE(pc.SetDomain(""));
-  EXPECT_TRUE(pc.SetPath(""));
-  EXPECT_TRUE(pc.SetExpires(""));
-  EXPECT_TRUE(pc.SetMaxAge(""));
+  EXPECT_TRUE(pc.SetDomain(std::string()));
+  EXPECT_TRUE(pc.SetPath(std::string()));
+  EXPECT_TRUE(pc.SetExpires(std::string()));
+  EXPECT_TRUE(pc.SetMaxAge(std::string()));
   EXPECT_TRUE(pc.SetIsSecure(false));
   EXPECT_TRUE(pc.SetIsHttpOnly(false));
   EXPECT_TRUE(pc.SetName("name2"));
   EXPECT_TRUE(pc.SetValue("value2"));
   EXPECT_FALSE(pc.HasDomain());
   EXPECT_FALSE(pc.HasPath());
   EXPECT_FALSE(pc.HasExpires());
   EXPECT_FALSE(pc.HasMaxAge());
   EXPECT_FALSE(pc.IsSecure());
   EXPECT_FALSE(pc.IsHttpOnly());
   EXPECT_EQ("name2=value2", pc.ToCookieLine());
 }
 
 }  // namespace net