content/browser/download/download_file_impl.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_file_impl.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_file_impl.cc

diff --git a/content/browser/download/download_file_impl.cc b/content/browser/download/download_file_impl.cc

index ab959005fce3c45a96ba659c7537c8bbf37a3b1c..5286e0ca7f4c5962f7254d10c02cd83e6827d7d4 100644

--- a/content/browser/download/download_file_impl.cc

+++ b/content/browser/download/download_file_impl.cc

@@ -108,8 +108,8 @@ void DownloadFileImpl::RenameAndUniquify(

base::FilePath new_path(full_path);

- int uniquifier =

- file_util::GetUniquePathNumber(new_path, FILE_PATH_LITERAL(""));

+ int uniquifier = file_util::GetUniquePathNumber(

+ new_path, base::FilePath::StringType());

if (uniquifier > 0) {

new_path = new_path.InsertBeforeExtensionASCII(

base::StringPrintf(" (%d)", uniquifier));