Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: content/browser/download/base_file_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/base_file.cc ('k') | content/browser/download/download_file_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/base_file_unittest.cc
diff --git a/content/browser/download/base_file_unittest.cc b/content/browser/download/base_file_unittest.cc
index 799076d361d067705ba271d09a3f1861a604db9e..0e6239f0a0fd533e4b4c445644d1c154433233fb 100644
--- a/content/browser/download/base_file_unittest.cc
+++ b/content/browser/download/base_file_unittest.cc
@@ -54,7 +54,7 @@ class BaseFileTest : public testing::Test {
GURL(),
0,
false,
- "",
+ std::string(),
scoped_ptr<net::FileStream>(),
net::BoundNetLog()));
}
@@ -105,7 +105,7 @@ class BaseFileTest : public testing::Test {
GURL(),
0,
true,
- "",
+ std::string(),
scoped_ptr<net::FileStream>(),
net::BoundNetLog()));
}
@@ -145,7 +145,7 @@ class BaseFileTest : public testing::Test {
GURL(),
0,
false,
- "",
+ std::string(),
scoped_ptr<net::FileStream>(),
net::BoundNetLog());
@@ -171,7 +171,7 @@ class BaseFileTest : public testing::Test {
GURL(),
0,
false,
- "",
+ std::string(),
scoped_ptr<net::FileStream>(),
net::BoundNetLog());
EXPECT_EQ(DOWNLOAD_INTERRUPT_REASON_NONE,
@@ -503,7 +503,7 @@ TEST_F(BaseFileTest, MultipleWritesWithError) {
GURL(),
0,
false,
- "",
+ std::string(),
mock_file_stream_scoped_ptr.Pass(),
net::BoundNetLog()));
ASSERT_TRUE(InitializeFile());
@@ -550,7 +550,7 @@ TEST_F(BaseFileTest, AppendToBaseFile) {
GURL(),
kTestDataLength4,
false,
- "",
+ std::string(),
scoped_ptr<net::FileStream>(),
net::BoundNetLog()));
@@ -584,7 +584,7 @@ TEST_F(BaseFileTest, ReadonlyBaseFile) {
GURL(),
0,
false,
- "",
+ std::string(),
scoped_ptr<net::FileStream>(),
net::BoundNetLog()));
@@ -609,7 +609,7 @@ TEST_F(BaseFileTest, IsEmptyHash) {
EXPECT_TRUE(BaseFile::IsEmptyHash(empty));
std::string not_empty(BaseFile::kSha256HashLen, '\x01');
EXPECT_FALSE(BaseFile::IsEmptyHash(not_empty));
- EXPECT_FALSE(BaseFile::IsEmptyHash(""));
+ EXPECT_FALSE(BaseFile::IsEmptyHash(std::string()));
}
// Test that calculating speed after no writes.
« no previous file with comments | « content/browser/download/base_file.cc ('k') | content/browser/download/download_file_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698