ppapi/tests/test_x509_certificate_private.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/tests/test_x509_certificate_private.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/tests/test_x509_certificate_private.cc

diff --git a/ppapi/tests/test_x509_certificate_private.cc b/ppapi/tests/test_x509_certificate_private.cc

index 6aee30f56e5e88cae412501d7f8db69eed710557..fab2f210d714c0b8aaffb8b04057fdee4bddab5b 100644

--- a/ppapi/tests/test_x509_certificate_private.cc

+++ b/ppapi/tests/test_x509_certificate_private.cc

@@ -166,22 +166,30 @@ std::string TestX509CertificatePrivate::TestValidCertificate() {

PP_X509CERTIFICATE_PRIVATE_SUBJECT_COUNTRY_NAME, "US"));

ASSERT_TRUE(FieldMatchesString(certificate,

PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_NAME, "Google Inc"));

- ASSERT_TRUE(FieldMatchesString(certificate,

- PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_UNIT_NAME, ""));

+ ASSERT_TRUE(FieldMatchesString(

+ certificate,

+ PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_UNIT_NAME,

+ std::string()));

ASSERT_TRUE(FieldMatchesString(certificate,

PP_X509CERTIFICATE_PRIVATE_ISSUER_COMMON_NAME, "Thawte SGC CA"));

- ASSERT_TRUE(FieldMatchesString(certificate,

- PP_X509CERTIFICATE_PRIVATE_ISSUER_LOCALITY_NAME, ""));

- ASSERT_TRUE(FieldMatchesString(certificate,

- PP_X509CERTIFICATE_PRIVATE_ISSUER_STATE_OR_PROVINCE_NAME, ""));

- ASSERT_TRUE(FieldMatchesString(certificate,

- PP_X509CERTIFICATE_PRIVATE_ISSUER_COUNTRY_NAME, "ZA"));

+ ASSERT_TRUE(

+ FieldMatchesString(certificate,

+ PP_X509CERTIFICATE_PRIVATE_ISSUER_LOCALITY_NAME,

+ std::string()));

+ ASSERT_TRUE(FieldMatchesString(

+ certificate,

+ PP_X509CERTIFICATE_PRIVATE_ISSUER_STATE_OR_PROVINCE_NAME,

+ std::string()));

+ ASSERT_TRUE(FieldMatchesString(

+ certificate, PP_X509CERTIFICATE_PRIVATE_ISSUER_COUNTRY_NAME, "ZA"));

ASSERT_TRUE(FieldMatchesString(certificate,

PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_NAME,

"Thawte Consulting (Pty) Ltd."));

- ASSERT_TRUE(FieldMatchesString(certificate,

- PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_UNIT_NAME, ""));

+ ASSERT_TRUE(FieldMatchesString(

+ certificate,

+ PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_UNIT_NAME,

+ std::string()));

ASSERT_FALSE(FieldIsNull(certificate,

PP_X509CERTIFICATE_PRIVATE_SERIAL_NUMBER));

« no previous file with comments | « ppapi/tests/test_websocket.cc ('k') | remoting/client/plugin/chromoting_instance.cc » ('j') | no next file with comments »