Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Side by Side Diff: ppapi/tests/test_x509_certificate_private.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ppapi/tests/test_websocket.cc ('k') | remoting/client/plugin/chromoting_instance.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/tests/test_x509_certificate_private.h" 5 #include "ppapi/tests/test_x509_certificate_private.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <limits> 8 #include <limits>
9 9
10 #include "ppapi/cpp/private/x509_certificate_private.h" 10 #include "ppapi/cpp/private/x509_certificate_private.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 ASSERT_TRUE(FieldMatchesString(certificate, 159 ASSERT_TRUE(FieldMatchesString(certificate,
160 PP_X509CERTIFICATE_PRIVATE_SUBJECT_COMMON_NAME, "www.google.com")); 160 PP_X509CERTIFICATE_PRIVATE_SUBJECT_COMMON_NAME, "www.google.com"));
161 ASSERT_TRUE(FieldMatchesString(certificate, 161 ASSERT_TRUE(FieldMatchesString(certificate,
162 PP_X509CERTIFICATE_PRIVATE_SUBJECT_LOCALITY_NAME, "Mountain View")); 162 PP_X509CERTIFICATE_PRIVATE_SUBJECT_LOCALITY_NAME, "Mountain View"));
163 ASSERT_TRUE(FieldMatchesString(certificate, 163 ASSERT_TRUE(FieldMatchesString(certificate,
164 PP_X509CERTIFICATE_PRIVATE_SUBJECT_STATE_OR_PROVINCE_NAME, "California")); 164 PP_X509CERTIFICATE_PRIVATE_SUBJECT_STATE_OR_PROVINCE_NAME, "California"));
165 ASSERT_TRUE(FieldMatchesString(certificate, 165 ASSERT_TRUE(FieldMatchesString(certificate,
166 PP_X509CERTIFICATE_PRIVATE_SUBJECT_COUNTRY_NAME, "US")); 166 PP_X509CERTIFICATE_PRIVATE_SUBJECT_COUNTRY_NAME, "US"));
167 ASSERT_TRUE(FieldMatchesString(certificate, 167 ASSERT_TRUE(FieldMatchesString(certificate,
168 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_NAME, "Google Inc")); 168 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_NAME, "Google Inc"));
169 ASSERT_TRUE(FieldMatchesString(certificate, 169 ASSERT_TRUE(FieldMatchesString(
170 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_UNIT_NAME, "")); 170 certificate,
171 PP_X509CERTIFICATE_PRIVATE_SUBJECT_ORGANIZATION_UNIT_NAME,
172 std::string()));
171 173
172 ASSERT_TRUE(FieldMatchesString(certificate, 174 ASSERT_TRUE(FieldMatchesString(certificate,
173 PP_X509CERTIFICATE_PRIVATE_ISSUER_COMMON_NAME, "Thawte SGC CA")); 175 PP_X509CERTIFICATE_PRIVATE_ISSUER_COMMON_NAME, "Thawte SGC CA"));
174 ASSERT_TRUE(FieldMatchesString(certificate, 176 ASSERT_TRUE(
175 PP_X509CERTIFICATE_PRIVATE_ISSUER_LOCALITY_NAME, "")); 177 FieldMatchesString(certificate,
176 ASSERT_TRUE(FieldMatchesString(certificate, 178 PP_X509CERTIFICATE_PRIVATE_ISSUER_LOCALITY_NAME,
177 PP_X509CERTIFICATE_PRIVATE_ISSUER_STATE_OR_PROVINCE_NAME, "")); 179 std::string()));
178 ASSERT_TRUE(FieldMatchesString(certificate, 180 ASSERT_TRUE(FieldMatchesString(
179 PP_X509CERTIFICATE_PRIVATE_ISSUER_COUNTRY_NAME, "ZA")); 181 certificate,
182 PP_X509CERTIFICATE_PRIVATE_ISSUER_STATE_OR_PROVINCE_NAME,
183 std::string()));
184 ASSERT_TRUE(FieldMatchesString(
185 certificate, PP_X509CERTIFICATE_PRIVATE_ISSUER_COUNTRY_NAME, "ZA"));
180 ASSERT_TRUE(FieldMatchesString(certificate, 186 ASSERT_TRUE(FieldMatchesString(certificate,
181 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_NAME, 187 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_NAME,
182 "Thawte Consulting (Pty) Ltd.")); 188 "Thawte Consulting (Pty) Ltd."));
183 ASSERT_TRUE(FieldMatchesString(certificate, 189 ASSERT_TRUE(FieldMatchesString(
184 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_UNIT_NAME, "")); 190 certificate,
191 PP_X509CERTIFICATE_PRIVATE_ISSUER_ORGANIZATION_UNIT_NAME,
192 std::string()));
185 193
186 ASSERT_FALSE(FieldIsNull(certificate, 194 ASSERT_FALSE(FieldIsNull(certificate,
187 PP_X509CERTIFICATE_PRIVATE_SERIAL_NUMBER)); 195 PP_X509CERTIFICATE_PRIVATE_SERIAL_NUMBER));
188 ASSERT_TRUE(FieldMatchesDouble(certificate, 196 ASSERT_TRUE(FieldMatchesDouble(certificate,
189 PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_BEFORE, 1238192407)); 197 PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_BEFORE, 1238192407));
190 ASSERT_TRUE(FieldMatchesDouble(certificate, 198 ASSERT_TRUE(FieldMatchesDouble(certificate,
191 PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_AFTER, 1269728407)); 199 PP_X509CERTIFICATE_PRIVATE_VALIDITY_NOT_AFTER, 1269728407));
192 ASSERT_TRUE(FieldMatchesBuffer(certificate, 200 ASSERT_TRUE(FieldMatchesBuffer(certificate,
193 PP_X509CERTIFICATE_PRIVATE_RAW, 201 PP_X509CERTIFICATE_PRIVATE_RAW,
194 reinterpret_cast<const char*>(kGoogleDer), sizeof(kGoogleDer))); 202 reinterpret_cast<const char*>(kGoogleDer), sizeof(kGoogleDer)));
(...skipping 24 matching lines...) Expand all
219 pp::X509CertificatePrivate null_certificate(instance_); 227 pp::X509CertificatePrivate null_certificate(instance_);
220 successful = null_certificate.Initialize(NULL, 0); 228 successful = null_certificate.Initialize(NULL, 0);
221 ASSERT_FALSE(successful); 229 ASSERT_FALSE(successful);
222 230
223 pp::X509CertificatePrivate bad_certificate(instance_); 231 pp::X509CertificatePrivate bad_certificate(instance_);
224 successful = bad_certificate.Initialize("acbde", 0); 232 successful = bad_certificate.Initialize("acbde", 0);
225 ASSERT_FALSE(successful); 233 ASSERT_FALSE(successful);
226 234
227 PASS(); 235 PASS();
228 } 236 }
OLDNEW
« no previous file with comments | « ppapi/tests/test_websocket.cc ('k') | remoting/client/plugin/chromoting_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698