chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc

diff --git a/chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc b/chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc

index 034655f4368ec431c508a6dbdbdf80aa9ab572e6..bba4b5c97168b2c57c6677f6287320d5e9e5bb03 100644

--- a/chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc

+++ b/chrome/renderer/safe_browsing/malware_dom_details_browsertest.cc

@@ -97,7 +97,7 @@ TEST_F(MalwareDOMDetailsTest, Everything) {

}

{ // >50 subframes, to verify kMaxNodes.

- std::string html = "";

+ std::string html = std::string();

for (int i = 0; i < 55; ++i) {

// The iframe contents is just a number.

GURL iframe_url(base::StringPrintf("%s%d", urlprefix, i));

@@ -113,7 +113,7 @@ TEST_F(MalwareDOMDetailsTest, Everything) {

}

{ // A page with >50 scripts, to verify kMaxNodes.

- std::string html = "";

+ std::string html = std::string();

for (int i = 0; i < 55; ++i) {

// The iframe contents is just a number.

GURL script_url(base::StringPrintf("%s%d", urlprefix, i));