chrome/common/net/x509_certificate_model.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/net/x509_certificate_model.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/net/x509_certificate_model.cc

diff --git a/chrome/common/net/x509_certificate_model.cc b/chrome/common/net/x509_certificate_model.cc

index 950b4f28bb9b2b783f6f82923890cfbc6935b4c7..e1f084785c203749eb515bfed086bfbba1ab36cf 100644

--- a/chrome/common/net/x509_certificate_model.cc

+++ b/chrome/common/net/x509_certificate_model.cc

@@ -61,7 +61,7 @@ std::string ProcessRawBytesWithSeparators(const unsigned char* data,

size_t kMin = 0U;

if (!data_length)

- return "";

+ return std::string();

ret.reserve(std::max(kMin, data_length * 3 - 1));