chrome/browser/ui/webui/version_ui.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/version_ui.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/version_ui.cc

diff --git a/chrome/browser/ui/webui/version_ui.cc b/chrome/browser/ui/webui/version_ui.cc

index 678492a381b61eff3ad49b17334c4b83085e4b12..a085d42581a3c5372e65522d4e78f8dcda31efca 100644

--- a/chrome/browser/ui/webui/version_ui.cc

+++ b/chrome/browser/ui/webui/version_ui.cc

@@ -92,7 +92,7 @@ content::WebUIDataSource* CreateVersionUIDataSource(Profile* profile) {

html_source->AddString("command_line",

WideToUTF16(CommandLine::ForCurrentProcess()->GetCommandLineString()));

#elif defined(OS_POSIX)

- std::string command_line = "";

+ std::string command_line = std::string();

typedef std::vector<std::string> ArgvList;

const ArgvList& argv = CommandLine::ForCurrentProcess()->argv();

for (ArgvList::const_iterator iter = argv.begin(); iter != argv.end(); iter++)