chrome/browser/safe_browsing/two_phase_uploader.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/two_phase_uploader.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/two_phase_uploader.cc

diff --git a/chrome/browser/safe_browsing/two_phase_uploader.cc b/chrome/browser/safe_browsing/two_phase_uploader.cc

index 9b6165eaf93958ed50f442a3cdb52989a9c2cd51..df58625e4e92b74b419e29f6fa83a323cc47a871 100644

--- a/chrome/browser/safe_browsing/two_phase_uploader.cc

+++ b/chrome/browser/safe_browsing/two_phase_uploader.cc

@@ -63,7 +63,7 @@ void TwoPhaseUploader::OnURLFetchComplete(const net::URLFetcher* source) {

if (!status.is_success()) {

LOG(ERROR) << "URLFetcher failed, status=" << status.status()

<< " err=" << status.error();

- Finish(status.error(), response_code, "");

+ Finish(status.error(), response_code, std::string());

return;

}

@@ -83,7 +83,7 @@ void TwoPhaseUploader::OnURLFetchComplete(const net::URLFetcher* source) {

if (!source->GetResponseHeaders()->EnumerateHeader(

NULL, kLocationHeader, &location)) {

LOG(ERROR) << "no location header";

- Finish(net::OK, response_code, "");

+ Finish(net::OK, response_code, std::string());

return;

}

DVLOG(1) << "upload location: " << location;