net/tools/quic/end_to_end_test.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/quic/end_to_end_test.cc

diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc

index e98c4ea17f6e5d829a333bdf93a250afadea8c0a..cb14db8e318c5e08dbc4166afe93dd60d6e60721 100644

--- a/net/tools/quic/end_to_end_test.cc

+++ b/net/tools/quic/end_to_end_test.cc

@@ -234,7 +234,7 @@ TEST_F(EndToEndTest, SeparateFinPacket) {

client_->SendMessage(request);

- client_->SendData("", true);

+ client_->SendData(std::string(), true);

client_->WaitForResponse();

EXPECT_EQ(kFooResponseBody, client_->response_body());

@@ -243,7 +243,7 @@ TEST_F(EndToEndTest, SeparateFinPacket) {

request.AddBody("foo", true);

client_->SendMessage(request);

- client_->SendData("", true);

+ client_->SendData(std::string(), true);

client_->WaitForResponse();

EXPECT_EQ(kFooResponseBody, client_->response_body());

EXPECT_EQ(200ul, client_->response_headers()->parsed_response_code());