media/audio/linux/alsa_output.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/linux/alsa_output.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/linux/alsa_output.cc

diff --git a/media/audio/linux/alsa_output.cc b/media/audio/linux/alsa_output.cc

index 4615d012e0e7d558033c99f06682c58d78cb110f..f3c3f9157f4c09e8bf4bc3851d37269dc366d1b9 100644

--- a/media/audio/linux/alsa_output.cc

+++ b/media/audio/linux/alsa_output.cc

@@ -523,7 +523,7 @@ std::string AlsaPcmOutputStream::FindDeviceForChannels(uint32 channels) {

const char* wanted_device = GuessSpecificDeviceName(channels);

if (!wanted_device)

- return "";

+ return std::string();

std::string guessed_device;

void** hints = NULL;