chrome/common/child_process_logging_posix.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/child_process_logging_posix.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/child_process_logging_posix.cc

diff --git a/chrome/common/child_process_logging_posix.cc b/chrome/common/child_process_logging_posix.cc

index 1690cd55bfb01dd82e4ee9820949c1b86dac6042..496103eda8f94b172de6622629cb2f03f05f88b2 100644

--- a/chrome/common/child_process_logging_posix.cc

+++ b/chrome/common/child_process_logging_posix.cc

@@ -66,7 +66,7 @@ void SetActiveURL(const GURL& url) {

void SetClientId(const std::string& client_id) {

std::string str(client_id);

- ReplaceSubstringsAfterOffset(&str, 0, "-", "");

+ ReplaceSubstringsAfterOffset(&str, 0, "-", std::string());

if (str.empty())

return;