chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc

diff --git a/chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc b/chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc

index fe4258804cebcd55e38c05df3834f6dc101242d8..fdb10b5da3432547175aacd0cd4d967308c21926 100644

--- a/chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc

+++ b/chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc

@@ -127,7 +127,7 @@ ConstrainedWebDialogDelegateViewGtk::ConstrainedWebDialogDelegateViewGtk(

void ConstrainedWebDialogDelegateViewGtk::OnDestroy(GtkWidget* widget) {

if (!impl_->closed_via_webui())

- GetWebDialogDelegate()->OnDialogClosed("");

+ GetWebDialogDelegate()->OnDialogClosed(std::string());

delete this;

}