dbus/values_util.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/values_util.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dbus/values_util.cc

diff --git a/dbus/values_util.cc b/dbus/values_util.cc

index 2e2d8e3e806b919866af70d451022c5257975cf6..7574f39a643d466b94fee5b437fdaf81cdd7d589 100644

--- a/dbus/values_util.cc

+++ b/dbus/values_util.cc

@@ -79,7 +79,7 @@ std::string GetTypeSignature(const base::Value& value) {

return "a{sv}";

default:

DLOG(ERROR) << "Unexpected type " << value.GetType();

- return "";

+ return std::string();

}