chrome/browser/google/google_util_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/google/google_util_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/google/google_util_unittest.cc

diff --git a/chrome/browser/google/google_util_unittest.cc b/chrome/browser/google/google_util_unittest.cc

index cf4c6100310831e803e765b2997e5cb10d3b34c6..75b706773b31708c103bafdcb65f1765052b3147 100644

--- a/chrome/browser/google/google_util_unittest.cc

+++ b/chrome/browser/google/google_util_unittest.cc

@@ -53,7 +53,7 @@ TEST(GoogleUtilTest, GoodHomePagesSecure) {

}

TEST(GoogleUtilTest, BadHomePages) {

- EXPECT_FALSE(IsGoogleHomePageUrl(""));

+ EXPECT_FALSE(IsGoogleHomePageUrl(std::string()));

// If specified, only the "www" subdomain is OK.

EXPECT_FALSE(IsGoogleHomePageUrl("http://maps.google.com"));

@@ -237,7 +237,7 @@ TEST(GoogleUtilTest, BadSearches) {

"http://www.google.com/search/nogood?q=something"));

EXPECT_FALSE(IsGoogleSearchUrl(

"http://www.google.com/webhp/nogood#q=something"));

- EXPECT_FALSE(IsGoogleSearchUrl(""));

+ EXPECT_FALSE(IsGoogleSearchUrl(std::string()));

// Case sensitive paths.

EXPECT_FALSE(IsGoogleSearchUrl(