chrome/browser/extensions/webstore_installer.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_installer.cc

diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc

index 81db7ed404cca5d0c3bc6cf0ccbc3c9738c06aac..f5f4d6879b6a25ad8568bc8ea55274cc3eb8a231 100644

--- a/chrome/browser/extensions/webstore_installer.cc

+++ b/chrome/browser/extensions/webstore_installer.cc

@@ -125,7 +125,8 @@ void GetDownloadFilePath(

base::FilePath file =

directory.AppendASCII(id + "_" + random_number + ".crx");

- int uniquifier = file_util::GetUniquePathNumber(file, FILE_PATH_LITERAL(""));

+ int uniquifier =

+ file_util::GetUniquePathNumber(file, FILE_PATH_LITERAL(std::string()));

if (uniquifier > 0) {

file = file.InsertBeforeExtensionASCII(

base::StringPrintf(" (%d)", uniquifier));