chrome/browser/extensions/extension_pref_value_map_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_pref_value_map_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_pref_value_map_unittest.cc

diff --git a/chrome/browser/extensions/extension_pref_value_map_unittest.cc b/chrome/browser/extensions/extension_pref_value_map_unittest.cc

index bfa573f7c78d267c98ad1f8a47d408bc71996237..62734ff18053fa1858bdc413bb6084c67788b9e9 100644

--- a/chrome/browser/extensions/extension_pref_value_map_unittest.cc

+++ b/chrome/browser/extensions/extension_pref_value_map_unittest.cc

@@ -45,7 +45,7 @@ class ExtensionPrefValueMapTestBase : public BASECLASS {

// Returns an empty string if the key is not set.

std::string GetValue(const char * key, bool incognito) const {

const Value *value = epvm_.GetEffectivePrefValue(key, incognito, NULL);

- std::string string_value = "";

+ std::string string_value = std::string();

if (value)

value->GetAsString(&string_value);

return string_value;