chrome/test/perf/url_fetch_test.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/perf/url_fetch_test.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/perf/url_fetch_test.cc

diff --git a/chrome/test/perf/url_fetch_test.cc b/chrome/test/perf/url_fetch_test.cc

index 6c8712f7f65326a707ab313aa77f8e2dc72f2090..2cffb687710c6204c81c90a488afadd8c339c5d4 100644

--- a/chrome/test/perf/url_fetch_test.cc

+++ b/chrome/test/perf/url_fetch_test.cc

@@ -77,8 +77,8 @@ class UrlFetchTest : public UIPerfTest {

"window.domAutomationController.send(%s);", var_to_fetch);

std::wstring value;

- bool success = tab->ExecuteAndExtractString(L"", ASCIIToWide(script),

- &value);

+ bool success = tab->ExecuteAndExtractString(

+ std::wstring(), ASCIIToWide(script), &value);

ASSERT_TRUE(success);

result->javascript_variable = WideToUTF8(value);

}