chrome/browser/plugins/plugin_metadata_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_metadata_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/plugins/plugin_metadata_unittest.cc

diff --git a/chrome/browser/plugins/plugin_metadata_unittest.cc b/chrome/browser/plugins/plugin_metadata_unittest.cc

index 3e3bf998e30a7dafce91f3c51f01678e25c45d5c..b542b1b191def9edef0a61ca127abacdc7a8e308 100644

--- a/chrome/browser/plugins/plugin_metadata_unittest.cc

+++ b/chrome/browser/plugins/plugin_metadata_unittest.cc

@@ -34,9 +34,11 @@ TEST(PluginMetadataTest, SecurityStatus) {

PluginMetadata plugin_metadata("claybrick-writer",

ASCIIToUTF16("ClayBrick Writer"),

- true, GURL(), GURL(),

+ true,

+ GURL(),

ASCIIToUTF16("ClayBrick"),

- "");

+ std::string());

#if defined(OS_LINUX)

EXPECT_EQ(kRequiresAuthorization,

GetSecurityStatus(&plugin_metadata, "1.2.3"));