sync/syncable/directory_backing_store.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/directory_backing_store.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Re-run on ToT, revert third_party changes and fix vexing parses. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/syncable/directory_backing_store.cc

diff --git a/sync/syncable/directory_backing_store.cc b/sync/syncable/directory_backing_store.cc

index f0b87be07b3bb0dcf2847cf757b8f3b144cec6ce..6d11e7f8be6f313be7813209bd11c238626820a7 100644

--- a/sync/syncable/directory_backing_store.cc

+++ b/sync/syncable/directory_backing_store.cc

@@ -1269,7 +1269,7 @@ bool DirectoryBackingStore::CreateTables() {

"?);")); // bag_of_chips

s.BindString(0, dir_name_); // id

s.BindString(1, dir_name_); // name

- s.BindString(2, ""); // store_birthday

+ s.BindString(2, std::string()); // store_birthday

// TODO(akalin): Remove this unused db_create_version field. (Or

// actually use it for something.) http://crbug.com/118356

s.BindString(3, "Unknown"); // db_create_version